search

theforeman / foreman-documentation

Documentation for the Foreman Project and its ecosystem
https://docs.theforeman.org
Creative Commons Attribution Share Alike 4.0 International
22 stars 95 forks source link

Fix hidden headings behind navigation bar [upstream only] #3454

Closed Lennonka closed 1 week ago

Lennonka commented 1 week ago

What changes are you introducing?

Fixing problem with misplaced headings when clicking an item in the TOC

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

UX improvement for Foreman Docs.

Previously, when you clicked an item in the table of contents, the browser scrolled to the top of the page and the actual heading was hidden behind the navigation bar. With this fix, the heading is visible.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

Please cherry-pick my commits into:

github-actions[bot] commented 1 week ago

The PR preview for 3a6b064a9fd3281eff52172b0eb71859839ea03c is available at theforeman-foreman-documentation-preview-pr-3454.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka commented 1 week ago

I did it!!! :tada:

Lennonka commented 1 week ago

Aren't we going to cherry pick it to stable branches?

ekohl commented 1 week ago

We probably should, but on my phone now. Anyone who can do it before I get to it should feel free to do so

Lennonka commented 1 week ago

Cherry picked to supported Foreman releases: