search

theforeman / foreman-infra

Puppet modules and scripts to manage Foreman project infrastructure
https://theforeman.github.io/foreman-infra
Apache License 2.0
23 stars 51 forks source link

Use checksum to detect RPM changes and drop the use of --archive #1958

Closed ehelms closed 8 months ago

ehelms commented 11 months ago

The --archive option includes --times implicitly that preserves modification time and results in all RPMs being thought of as changed. Instead we explicitly define the options that are included in --archive and drop the use of --times.

We need to apply some of the same rsync logic here to ensure we do not re-copy the RPMs each and every time. As you can see from this test (https://ci.theforeman.org/blue/organizations/jenkins/foreman-nightly-rpm-pipeline/detail/foreman-nightly-rpm-pipeline/2076/pipeline/) pipeline all the files were copied over from stagingyum.

ekohl commented 9 months ago

With the work that @evgeni did, is this still needed?

evgeni commented 9 months ago

No, I think it's not needed anymore