use NodeJS 18.x on EL9 CI nodes

theforeman / foreman-infra

Puppet modules and scripts to manage Foreman project infrastructure

https://theforeman.github.io/foreman-infra

Apache License 2.0

24 stars 51 forks source link

use NodeJS 18.x on EL9 CI nodes #2071

Closed evgeni closed 1 week ago

evgeni commented 1 month ago

Requires

[x] https://github.com/theforeman/jenkins-jobs/pull/463
[ ] Foreman 3.9 to be EOL

ehelms commented 1 month ago

Do we know for certain the tests will fail with 18? We could try it :)

evgeni commented 1 month ago

Webpack 3 doesn't like the new Node afaik

evgeni commented 1 month ago

@ekohl @ehelms need a few brains here…

We have two kinds of Jenkins nodes: those labeled fast and those not labeled fast
Only fast ones get the heavy NodeJS involved jobs
We do not differentiate in Puppet, so both kinds get NodeJS installed
My idea was to keep the fast ones on EL8 until 3.9 is ded, and upgrade the "slow" ones already.
This can be done using this PR, but…

We do not need NodeSource anymore. CentOS has new enough NodeJS. And someone even made puppet-nodejs support DNF modules in https://github.com/voxpupuli/puppet-nodejs/pull/488 (which is in 11.x) ;) However, I am sure that flipping the existing setup to DNF modules would be a disaster.

How crazy would be to just stop managing NodeJS on EL8 completely, and instead use modules on EL9? The existing Jenkins nodes would be unaffected and new ones on EL9 "cleaner".

ehelms commented 1 month ago

Only fast ones get the heavy NodeJS involved jobs

I wonder if the reasoning behind this still holds true.

We do not need NodeSource anymore. CentOS has new enough NodeJS. And someone even made puppet-nodejs support DNF modules in voxpupuli/puppet-nodejs#488 (which is in 11.x) ;) However, I am sure that flipping the existing setup to DNF modules would be a disaster.

How crazy would be to just stop managing NodeJS on EL8 completely, and instead use modules on EL9? The existing Jenkins nodes would be unaffected and new ones on EL9 "cleaner".

Fine by me.

evgeni commented 1 month ago

Only fast ones get the heavy NodeJS involved jobs

I wonder if the reasoning behind this still holds true.

It does. OSUOSL nodes are significantly slower than Conova/Netways.

ehelms commented 1 month ago

It does. OSUOSL nodes are significantly slower than Conova/Netways.

I more meant to question whether our NodeJS testing has gotten faster as we use newer node and we've re-architected how it all gets built.

evgeni commented 1 month ago

it's even an upgrade of the Node version, as the old repo is not updated anymore:

[vagrant@jenkins-node-el9 ~]$ node --version
v18.17.1

[vagrant@jenkins-node-el9 ~]$ node --version
v18.19.1

evgeni commented 1 month ago

It does. OSUOSL nodes are significantly slower than Conova/Netways.

I more meant to question whether our NodeJS testing has gotten faster as we use newer node and we've re-architected how it all gets built.

Ah, well, I am not sure. I recall the original split was because of Ruby, not NodeJS and all tests run on the same jenkins node once they start?

evgeni commented 2 weeks ago

3.9 is about to go EOL, but I'd also wait for all 3.9 jobs to be dropped from jenkins.jobs. Other than that, 👍

This is scoped to EL9 only, so it won't affect current nodes anyway, but yeah.

evgeni commented 1 week ago

We declared 3.9 dead, so I am merging this