Closed ehelms closed 2 weeks ago
Shouldn't this PR have triggered tests still?
Should it?
On Fri, Oct 4, 2024, 2:11 PM Evgeni Golov @.***> wrote:
Shouldn't this PR have triggered tests still?
— Reply to this email directly, view it on GitHub https://github.com/ehelms/foreman-quadlet/pull/22#issuecomment-2394310930, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHT463W4WYC4UNGOWQB73ZZ3K3JAVCNFSM6AAAAABPLZ6JWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGMYTAOJTGA . You are receiving this because you authored the thread.Message ID: @.***>
The PR changes files outside of container images, so yes
We should add tests in this area, but for now, let's just make things more efficient (https://github.com/ehelms/foreman-quadlet/issues/23)