search

theforeman / foreman_ansible_inventory

Foreman dynamic inventory script for ansible - Now merged into Ansible itself
GNU General Public License v3.0
70 stars 31 forks source link

read foreman.ini from environment if set #11

Closed wwitzel3 closed 8 years ago

wwitzel3 commented 8 years ago

Allow for reading foreman.ini from the environment.

agx commented 8 years ago

We should only add this to the list of config files if the env var is actually set otherwise:

os.path.expanduser(os.path.expandvars(os.environ.get('FOREMAN_INI_PATH'))) Traceback (most recent call last): File "", line 1, in File "/usr/lib/python2.7/posixpath.py", line 287, in expandvars if '$' not in path: TypeError: argument of type 'NoneType' is not iterable

wwitzel3 commented 8 years ago

Thank you, fixed.

dLobatog commented 8 years ago

@wwitzel3 Thanks for the contribution. It looks good to me, can you add info on how to use it to the README? Ready to merge after that unless @agx has any qualms

agx commented 8 years ago

On Tue, Apr 12, 2016 at 12:17:33PM -0700, Daniel Lobato García wrote:

@wwitzel3 Thanks for the contribution. It looks good to me, can you add info on how to use it to the README? Ready to merge after that unless @agx has any qualms

No objections, some info in README wold be awesome though.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/theforeman/foreman_ansible_inventory/pull/11#issuecomment-209060995

wwitzel3 commented 8 years ago

Is that README update good? Thanks.

agx commented 8 years ago

On Wed, Apr 13, 2016 at 09:00:16AM -0700, Wayne Witzel III wrote:

Is that README update good? Thanks.

Merged now. Thanks! -- Guido