search

theforeman / foreman_ansible_inventory

Foreman dynamic inventory script for ansible - Now merged into Ansible itself
GNU General Public License v3.0
70 stars 31 forks source link

add support for pagination #4

Closed brandonweeks closed 8 years ago

agx commented 8 years ago

I was about to merge something similar but my intend was to bump per_page a lot first so we reduce the number of API requests. What do you think?

brandonweeks commented 8 years ago

That was going to be my next PR... 😄 I was thinking a default of a 50 or 100 as a default but it should definitely be configurable.

agx commented 8 years ago

Shoudn't we set this to INT_MAX or another large number by default and be done with it (adding your pagination patch as well of course). @dLobatog do you see any drawbacks when pulling a large number of hosts?

agx commented 8 years ago

Merged now, my comments still hold but we can improve from here on. Thanks a lot!