search

theforeman / foreman_ansible_inventory

Foreman dynamic inventory script for ansible - Now merged into Ansible itself
GNU General Public License v3.0
70 stars 31 forks source link

250 wasn't including all our facts #43

Open mtward opened 7 years ago

jkroepke commented 7 years ago

Also 1000 does not include all facts.

Instead setting per-page higher, the function should be fixed.

agx commented 7 years ago

But we're paging through the results. @dLobatog any idea why this does not work?

jkroepke commented 7 years ago

Because the paging does only work for hosts, not for facts.

Am 05.07.2017 um 19:16 schrieb Guido Günther notifications@github.com:

But we're paging through the results. @dLobatog https://github.com/dlobatog any idea why this does not work?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/theforeman/foreman_ansible_inventory/pull/43#issuecomment-313168308, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfQC3xkG_SPQYL8_zwjVIRASkDlDCUvks5sK8TmgaJpZM4LuG8t .

agx commented 7 years ago

On Wed, Jul 05, 2017 at 05:20:52PM +0000, Jan-Otto Kröpke wrote:

Because the paging does only work for hosts, not for facts.

Then we shoud bump this to $max. Is that 1000?

Am 05.07.2017 um 19:16 schrieb Guido Günther notifications@github.com:

But we're paging through the results. @dLobatog https://github.com/dlobatog any idea why this does not work?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/theforeman/foreman_ansible_inventory/pull/43#issuecomment-313168308, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfQC3xkG_SPQYL8_zwjVIRASkDlDCUvks5sK8TmgaJpZM4LuG8t .

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/theforeman/foreman_ansible_inventory/pull/43#issuecomment-313169392

jkroepke commented 7 years ago

In our setup, we have 10000 configured. Our metal have many many disks (oracle database) with more then 2000 facts.

Am 05.07.2017 um 19:23 schrieb Guido Günther notifications@github.com:

On Wed, Jul 05, 2017 at 05:20:52PM +0000, Jan-Otto Kröpke wrote:

Because the paging does only work for hosts, not for facts.

Then we shoud bump this to $max. Is that 1000?

Am 05.07.2017 um 19:16 schrieb Guido Günther notifications@github.com:

But we're paging through the results. @dLobatog https://github.com/dlobatog any idea why this does not work?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/theforeman/foreman_ansible_inventory/pull/43#issuecomment-313168308 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABfQC3xkG_SPQYL8_zwjVIRASkDlDCUvks5sK8TmgaJpZM4LuG8t

.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub:

https://github.com/theforeman/foreman_ansible_inventory/pull/43#issuecomment-313169392

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/theforeman/foreman_ansible_inventory/pull/43#issuecomment-313170056, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfQCz2orlN4tQ5gyZqcB8O5siQCLoneks5sK8aPgaJpZM4LuG8t .