search

theforeman / foreman_azure_rm

Adds Azure Resource Manager as a compute resource for The Foreman
GNU General Public License v3.0
9 stars 24 forks source link

Fixes ##32640 - Implement Azure Extension Microsoft.HpcCompute/NvidiaGpuDriver{Linux,…Windows}/1.3 to deploy NVIDIA GPU drivers #127

Closed eLvErDe closed 3 years ago

eLvErDe commented 3 years ago

Everything is in the title :)

I'm not sure it actually works on Linux but the extension is available so I made it available as well. Both are set using a checkbox from foreman interface and actual state is read when displaying existing VM. It can also be saved in compute profiles.

I still need to check it's working using REST API but I think it should.

eLvErDe commented 3 years ago

Do not merge yet, just saw an issue

chris1984 commented 3 years ago

@eLvErDe is this good to test?

eLvErDe commented 3 years ago

Sorry, yes it is

eLvErDe commented 3 years ago

iIt's working fine using compute profiles, change from rails form at deployment time and REST API. It's also correctly updated on existing VM when removing it or adding it using Azure web interface.

Only tested on Windows, not sure it's really applicable on Linux but the extension exists so I implemented it as well.

chris1984 commented 3 years ago

Sounds good, will start to test and we can get a new release out

eLvErDe commented 3 years ago

You can easily test with a windows machine, choose a NVIDIA based profile (e.g: NV6) a check the tickbox. Once deployed you should find NVIDIA software deployed in the VM. Then, go to azure interface and remove the Nvidia extension from the VM, check it's removed in foreman (edit host).

chris1984 commented 3 years ago

You can easily test with a windows machine, choose a NVIDIA based profile (e.g: NV6) a check the tickbox. Once deployed you should find NVIDIA software deployed in the VM. Then, go to azure interface and remove the Nvidia extension from the VM, check it's removed in foreman (edit host).

Verified that as well, just didn't make a screenshot :) I will update my testing steps though to reflect that.

Want me to demo this next Foreman demo?

eLvErDe commented 3 years ago

Sure :-)

If people are interested in ! Also ping them regarding my AWS PR stuck for ages :D

eLvErDe commented 3 years ago

Hello @chris1984,

Would you consider releasing a new version with NVIDIA support ?

Regards, Adam.

chris1984 commented 3 years ago

Hello @chris1984,

Would you consider releasing a new version with NVIDIA support ?

Regards, Adam.

Hey @eLvErDe

Release is made: https://rubygems.org/gems/foreman_azure_rm/versions/2.2.5

Enjoy!