Fixes #35481 - Remove hard coded sudo command in script extension

chris1984 commented 2 years ago

What are the changes introduced in this pull request?

When building a VM with Forman in Microsoft Azure, it looks like we hard coded adding azureuser ALL=(ALL) NOPASSWD:ALL in the /etc/sudoers.d/waagent file This no longer is needed since Azure drops in a 90-cloud-init-users in a newly provisioned VM. We can see the contents of that file here:

[root@Toledo123 ~]# cat /etc/sudoers.d/90-cloud-init-users 
# Created by cloud-init v. 19.4 on Tue, 03 Aug 2021 14:30:54 +0000

# User rules for azureuser
azureuser ALL=(ALL) NOPASSWD:ALL

# User rules for azureuser
azureuser ALL=(ALL) NOPASSWD:ALL

The hard-coded value actually introduced another bug, we were trying to echo that sudo command even if a user didn't put anything in the script_command or script_uri fields, which would then add the Linux Script VM Extension to the VM when a user didn't ask for it.

This PR does two things:

Remove the hardcoded script command so that if a user does not pass anything into script_command and script_uri we do not create the VM extension for that VM.
The sudo command was not working so if a user did put in a script_command and script_uri the command would fail inside the script.

Considerations taken when implementing this change?

Tested on Foreman develop - No regressions
Tested on Satellite 6.12 - No regressions
Tested on Satellite 6.11 - No regressions

What are the testing steps for this pull request?

Check out PR
Create a VM and do not put anything in script_command and script_uri and verify VM got created without the Linux Script extension
Create a vm and use the following for the script commands
- script_uris = https://raw.githubusercontent.com/SatelliteQE/robottelo/master/tests/foreman/data/uri.sh
- script_command = sudo sh /var/lib/waagent/custom-script/download/0/uri.sh
Verify you can see Hello! in /var/tmp/hello.txt.

chris1984 commented 2 years ago

@pendor If you have time can this get a review? BZ for reference https://bugzilla.redhat.com/show_bug.cgi?id=2088529

chris1984 commented 2 years ago

Test failures are unrelated, will make a pr to fix them, and will update my commit message to make the redmine check happy once it's reviewed/acked.

chris1984 commented 2 years ago

@Ron-Lavi here is the pr

theforeman / foreman_azure_rm