Fixes #28162 - Custom script, file uris and image_id get blank

apuntamb commented 4 years ago

This comment also still needs addressing.

done.

apuntamb commented 4 years ago

Made a couple more changes in order to handle all use cases around script command and uris:

For compute profile
For host create opening VM tab (when all attributes are nil)
For host edit page when no script command and uri is given
For host edit page when script command and uri is given (This needed extra handling since we do have @azure_vm.resources as not nil even when user does not pass these two attributes since we inject the sudoers command purposely. Hence, extra checks. Works for all above scenarios now.

ShimShtein commented 4 years ago

Merged, thanks @apuntamb!

theforeman / foreman_azure_rm