search

theforeman / foreman_cockpit

:rocket: Display console and journal of Cockpit-enabled hosts in Foreman - now replaced by Remote Execution's cockpit integration
GNU General Public License v3.0
18 stars 13 forks source link

replace alias_method_chain with Module.prepend #15

Closed timogoebel closed 5 years ago

timogoebel commented 6 years ago

This plugin conflicts with foreman_monitoring (see https://github.com/theforeman/foreman_monitoring/issues/30) because it still uses alias_method_chain. This PR replaces the deprecated alias_method_chain with Module.prepend.

dgoetz commented 6 years ago

@dLobatog Can you merge this, please? Foreman 1.17 with other plugins installed which use alias_method_chain or Module.prepend it will cause the Cockpit button to not show up, with the patch applied it works fine.

tbrisker commented 5 years ago

Merging this, someone will need to take care of the plugin to release a newer version containing it.

paulcalabro commented 5 years ago

Awesome, I can confirm this fixed my issue as well.

rholloway commented 5 years ago

Yes, looking forward to release with this in it as well. Note to self and others less familiar with foreman setup, for me the file (Ubuntu 18.04) was nested in following (installed using foreman-installer)

/usr/share/foreman/vendor/ruby/<version>/gems/foreman_cockpit_<version>/...