search

theforeman / foreman_column_view

A simple Foreman plugin showcasing Deface for altering the Hosts view
GNU General Public License v3.0
23 stars 15 forks source link

Handle column widths and overflow #18

Closed tbrisker closed 8 years ago

tbrisker commented 9 years ago

This PR takes advantage of changes made by https://github.com/theforeman/foreman/pull/2789 to allow column width control and ellipsizing text.

GregSutcliffe commented 8 years ago

Aplologies for the very slow reply @tbrisker. Just played around with this - it seems to me that it doesn;t really solve the overflow problem, it merely moves it (instead of my column_view column overflowing, now my action buttons overflow instead). Can we add ellipsis to the column maybe?

discreet commented 8 years ago

Just tested this patch in my lab environment running 1.11.2 and it does seem that this does not resolve the issue but just moved it to something else.

tbrisker commented 8 years ago

I opened https://github.com/theforeman/foreman/pull/3884 that should fix the issue with this PR allowing un-breaking this plugin.

GregSutcliffe commented 8 years ago

Along with the core PR, seems to work great! Merged as 9ad8de5, ty @tbrisker!

I'll get a new release out shortly (so that the plugin works with 1.13), but the core commit is slated for 1.13.1 so users should be aware that the UI fix won't happen until then.

discreet commented 8 years ago

Awesome! Can't thank you enough for this @tbrisker

GregSutcliffe commented 8 years ago

For those following this, 1.13.1 isout now, so this should all be working again. Thanks again @tbrisker!