search

theforeman / foreman_column_view

A simple Foreman plugin showcasing Deface for altering the Hosts view
GNU General Public License v3.0
23 stars 15 forks source link

Fix plugin for 1.17 #31

Closed GregSutcliffe closed 6 years ago

GregSutcliffe commented 6 years ago

@tbrisker could you review? I'm not sure if this new style is 1.17 only, or ok for 1.16?

ekohl commented 6 years ago

Not entirely required but it's nice if plugins have a table of supported foreman versions with matching plugin versions in their README. Something like https://github.com/theforeman/foreman_bootdisk#compatibility makes life easier for users and packagers.

GregSutcliffe commented 6 years ago

@ekohl added. It's been a while since I did any serious testing so this is from memory, but it's a start :)

GregSutcliffe commented 6 years ago

@bastilian updated :)

GregSutcliffe commented 6 years ago

Merged, thanks both. will cut a release.