search

theforeman / foreman_column_view

A simple Foreman plugin showcasing Deface for altering the Hosts view
GNU General Public License v3.0
23 stars 15 forks source link

exception with foreman 1.4 #7

Closed cristifalcas closed 6 years ago

cristifalcas commented 10 years ago

It seems it's not working with foreman 1.4.

I installed it like so: yum install ruby193-rubygem-foreman_column_view
service httpd restart

When I connect to foreman there is no extra tab in the hosts list.

When I click one of the hosts I get the following exception:

Warning! undefined method `reject' for nil:NilClass

If you feel this is an error with Foreman itself, please open a new issue with Foreman ticketing system, You would probably need to attach the Full trace and relevant log entries. NoMethodError undefined method reject' for nil:NilClass app/views/hosts/_overview.html.erb:18:in_app_views_hostsoverview_html_erb2940846528551098427_67405340' app/views/hosts/show.html.erb:25:in _app_views_hosts_show_html_erb___1825293817106228945_66122160' app/models/concerns/foreman/thread_session.rb:33:inclear_thread' lib/middleware/catch_json_parse_errors.rb:9:in `call'

GregSutcliffe commented 10 years ago

Yeah I haven't looked into updating it for 1.4 yet, and that's not going to happen until the end of next week, as I'm about to leave for FOSDEM and CfgMgmt. Patches welcome, or wait til next week :)

cristifalcas commented 10 years ago

Have fun at fosdem.

Have no idea about ruby, so I will wait.

Flauschbaellchen commented 10 years ago

Any news about updating this addon to work with foreman 1.4/1.4.1?

As a (possible related sidenote)., the last example from the front page didn't worked for me:

undefined method `drop' for :bmc_available?:Symbol
sect0id commented 10 years ago

Hello, don't work on Foreman 1.4.2. I install with "yum install ruby193-rubygem-foreman_column_view", restart foreman, in foreman about box, i see " Name Description Author Version foreman_column_view Displays an additional column in the Foreman Hosts view and/or additional entries in the Host show page Greg Sutcliffe 0.2.0 " but, i don't see new columns in all hosts page.

in 1.3 all ok

thank you for plugin

domcleal commented 10 years ago

The original error in this report should have been fixed in 3cf23e07f, it was caused when no configuration had been added. There aren't any incompatibilities with 1.4 that I'm aware of.

@sect0id regarding your issue, have you actually configured it? See /usr/share/foreman/config/settings.plugins.d/ and there's an example file you need to remove the suffix from, and add configuration as per the README.

GregSutcliffe commented 6 years ago

Closing this very old issue, please open a new one if there's still an issue here (apart from compatibility with 1.17, see #31 for that)