Change wording as actual deletion date may be before the given date

theforeman / foreman_expire_hosts

Foreman plugin for limiting host lifetime

GNU General Public License v3.0

5 stars 12 forks source link

Change wording as actual deletion date may be before the given date #36

Closed gqueri closed 5 years ago

gqueri commented 5 years ago

Every day users will get a new mail warning them that the host will be deleted. The date is only valid the first time, so we would like to change the wording to make it less confusing.

theforeman-bot commented 5 years ago

Can one of the admins verify this patch?

timogoebel commented 5 years ago

Every day users will get a new mail warning them that the host will be deleted.

Thanks for the patch, but isn't that the actual problem? I guess every user should only get a warning once, right?

gqueri commented 5 years ago

it looks like they are getting the mail every day until the host is deleted...

timogoebel commented 5 years ago

it looks like they are getting the mail every day until the host is deleted...

Yes, the code suggests exactly that. I'll take a look and see if we can change this easily.

timogoebel commented 5 years ago

@gqueri: I've opened a PR in #37, that should address this behavior. If the host is already shut down, it will not send a notification. If you don't mind, please try it out and provide some feedback.