migrate bootstrap-datepicker to plain rails

theforeman / foreman_expire_hosts

Foreman plugin for limiting host lifetime

GNU General Public License v3.0

5 stars 12 forks source link

migrate bootstrap-datepicker to plain rails #45

Closed timogoebel closed 4 years ago

timogoebel commented 4 years ago

This should fix #44.

laugmanuel commented 4 years ago

It seems to fix the problem for me. However the UI is not very pretty - the dropdown is cut after one/two characters which makes reading the values very difficult.

timogoebel commented 4 years ago

Currently, there are still some issues with correctly parsing the parameters.

timogoebel commented 4 years ago

@laugmanuel: I fixed the remaining issue, mind taking another look?

laugmanuel commented 4 years ago

I had a look at the plugin again. Looks good to me now. I've tested it with Foreman 1.24 RC3 in bulk mode as well as with single hosts.

laugmanuel commented 4 years ago

@timogoebel can I support on this?

timogoebel commented 4 years ago

@laugmanuel: Thanks, I'm trying to get the tests in #42 to pass since I want to merge this first.

timogoebel commented 4 years ago

Test failures were unrelated.

laugmanuel commented 4 years ago

Thanks @timogoebel