search

theforeman / foreman_expire_hosts

Foreman plugin for limiting host lifetime
GNU General Public License v3.0
5 stars 12 forks source link

Use the datepicker component from core #55

Closed kamils-iRonin closed 1 year ago

kamils-iRonin commented 4 years ago

fixes #52, fixes #69

image

timogoebel commented 4 years ago

Nice. We don‘t need a timepicker, the date is enough. And we also have another datepicker in the multiple action. :-)

kamils-iRonin commented 4 years ago

waiting for https://github.com/theforeman/foreman/pull/7404 and https://github.com/theforeman/foreman/pull/7406

timogoebel commented 4 years ago

The whole idea was to get rid of deface eventually. I'm wondering if we can add a helper (that calls mount_react_component?) in core so we don't need to use deface here.

kamils-iRonin commented 4 years ago

The whole idea was to get rid of deface eventually

actually, we don't need deface if we add the DatePicker component to the component registry in core, I don't know why this component is not added there

timogoebel commented 4 years ago

I think we should add it there. That’s a no-brainer inho.

kamils-iRonin commented 4 years ago

image image

timogoebel commented 4 years ago

@kamils-iRonin: Do you mind bumping the minimum required Foreman version in engine.rb?

timogoebel commented 4 years ago

@kamils-iRonin: This needs a rebase, now.

kamils-iRonin commented 3 years ago

@timogoebel rebased

laugmanuel commented 3 years ago

Hi @kamils-iRonin , I just had a look at this and in general this works nicely! I've just noticed that I don't see an error message on the GUI if I select a date in the past. The console however shows:

09:14:07 rails.1   | 2021-02-10T09:14:07 [E|app|a03d3c5f] Failed to save: Expired on must be in the future

I've tested with Foreman 2.5.0-develop. Can you verify this or is it a local problem?

ekohl commented 1 year ago

@kamils-iRonin can you rebase this now that I've merged the CI pipeline fixes?