search

theforeman / foreman_expire_hosts

Foreman plugin for limiting host lifetime
GNU General Public License v3.0
5 stars 12 forks source link

Use theforeman/actions for GitHub Actions configuration #75

Closed ekohl closed 10 months ago

ekohl commented 10 months ago

@evgeni this is the only repo where I tried to also test with Foreman versions and archiving the lock files fails. I suppose the cache key isn't long enough and needs more :(

evgeni commented 10 months ago

3.8 is failing, which I think is a test setup issue, not a code issue. should we just drop it from the matrix?

Edit: or pick https://github.com/theforeman/foreman/pull/9932 into 3.8?

ekohl commented 10 months ago

Edit: or pick theforeman/foreman#9932 into 3.8?

I wonder why it even needs PuppetRelatedHelper in the tests. Perhaps we can just drop that.

evgeni commented 10 months ago

Edit: or pick theforeman/foreman#9932 into 3.8?

I wonder why it even needs PuppetRelatedHelper in the tests. Perhaps we can just drop that.

WFM

evgeni commented 10 months ago

now it fails on the branches that do have the helper :see_no_evil:

ekohl commented 10 months ago

How about conditionally including the helper? Let's see what CI says.

ekohl commented 10 months ago

That's now green.