search

theforeman / foreman_fog_proxmox

Foreman plugin to add Proxmox compute resource based on fog-proxmox gem
GNU General Public License v3.0
105 stars 31 forks source link

Enable cluster node selection on create host. #124

Closed hlawatschek closed 4 years ago

hlawatschek commented 4 years ago

When using a proxmox cluster configuration, this enables the possibility to choose the target cluster node on new host creation.

tristanrobert commented 4 years ago

You PR is very interesting but could you please first post an issue describing the feature in order to discuss the many ways to implement it and to choose the best one for all users?

tristanrobert commented 4 years ago

it is a solution fixing #126

tristanrobert commented 4 years ago

@hlawatschek you can tell me what you would like in #126

sbernhard commented 4 years ago

Can this be merged or do you ask for some changes of this PR?

tristanrobert commented 4 years ago

Your PR is limited: it does not remove node from compute resource, it does not migrate vm when node is changed, it does not compute storages, bridges and so on depending on the node and above all it does not have tests. I am working on a solution that includes all these features with tests first. It is a little bit more complicated. https://github.com/theforeman/foreman_fog_proxmox/issues/126 has many consequences in the code that complicates it a little bit.

tristanrobert commented 4 years ago

Fixed in v0.10.0