Fixes ActionView::Template::Error vm_type Error

[Manisha15]

Fixes Issue: https://github.com/theforeman/foreman_fog_proxmox/issues/150

[tristanrobert]

Thank you for your PR. I understand your need but first I need to analyze and test why you need to rollback this feature. I need to test what is exactly your bug before to merge or not.

[Manisha15]

To produce the error you can pull my PR https://github.com/theforeman/foreman_bootdisk/pull/90 and try to create proxmox host using bootdisk as provision method on foreman with foreman_fog_proxmox > 0.9.x or @hakong also have same error and mentioned the way to produce it. TIA.

[tristanrobert]

ok @Manisha15 I will try your PR and test your bug.

[sbernhard]

@tristanrobert , did you have the time to test the PR from @Manisha15? How can we help to get this done as it blocks the change in foreman_bootdisk, too.

[Manisha15]

ok @Manisha15 I will try your PR and test your bug.

Hello @tristanrobert, Did you get the time to check this PR? It would be helpful if you can review this, so that the other blocked PR can also get merged. TIA

[tristanrobert]

@Manisha15 could you please complete your PR by deleting the two functions: vm_type(host) and node_id(host) in proxmox_vm_helper.rb. They are only used in _add_vm_type_to_nic_provider_specific_form.html.erb

[Manisha15]

@Manisha15 could you please complete your PR by deleting the two functions: vm_type(host) and node_id(host) in proxmox_vm_helper.rb. They are only used in _add_vm_type_to_nic_provider_specific_form.html.erb

Done !

[tristanrobert]

You have introduced a syntax error on proxmox_compute_attributes.rb file at line 57: delete the colon : at the end of the line. See CI build logs.

[sbernhard]

done :)

[tristanrobert]

Thank you @sbernhard and @Manisha15 !