Open btoneill opened 1 month ago
I have cleared up the rubocop and js errors. I think it's all pushed properly. I'm new at doing this stuff thru GitHub so apologies on figuring out the process.
The tests are failing, can you please fix them.
And can you please squash the commits into three which solve the problem and prepend fix:
to the commit message so that they get into release notes. You can refer to merged PRs for commit message.
Added option for turning backup on/off from Foreman so you can keep some disks from being backed up. Otherwise if you set it on the Proxmox side a foreman update will change it back. Was unable to use a checkbox as the default for backup is a blank setting and the ActionPack stuff doesn't pass thru an unchecked checkbox. So had to make it a pull down option list.
Removed the mac address upcase change because it causes every update of a host in Foreman to cause an update of the MAC address in proxmox because foreman uses the mac address in the format of the host and this causes it to always change if they don't match
For some reason the code is setting the id of the network device for proxmox to be the network name the OS thinks it is. For example, OS is ens18 and proxmox is net0. The code forced ens18 to the compute_attributes which causes Foreman to always think an update needs to be done. Log for this in debug mode is "Scheduling compute instance update because id changed it's value from 'net0' (String) to 'ens18' (String)". This fixes it so it properly uses the net0 instead of getting the name of the OS network device.