search

theforeman / foreman_fog_proxmox

Foreman plugin to add Proxmox compute resource based on fog-proxmox gem
GNU General Public License v3.0
106 stars 33 forks source link

Add linting to project #98

Closed quba42 closed 5 years ago

quba42 commented 5 years ago

Is your feature request related to a problem? Please describe. The foreman_fog_proxmox code base is currently not linted. A quick test with Rubocop in my local copy revealed 1272 style "offenses".

Describe the solution you'd like To introduce some Rubocop linting in some way shape or form. Preferably automatic, with a single authoritative Rubocop installation or settings.

Additional context Not sure what we would need to proceed with this, since I don't have any experience adding linting to a project on GitHub.

Any input by someone with relevant experience is welcome! Any opionions, thoughts, preferences, also welcome!

quba42 commented 5 years ago

Adhering to the same linting rules as foreman uses might be good for consistency.

quba42 commented 5 years ago

I guess this is fixed! Thanks, @m-bucher!