Return hook output on error

theforeman / foreman_hooks

Run custom hook scripts on Foreman events

http://m0dlx.com/blog/Extending_Foreman_quickly_with_hook_scripts.html

GNU General Public License v3.0

56 stars 50 forks source link

Return hook output on error #14

Closed stdietrich closed 8 years ago

stdietrich commented 10 years ago

This is probably an enhancement. If a hook fails, it would be helpful to return the error output of the hook to the user. This is mostly useful when users enter an incorrect value, which gets validated by the hook.

With #11 in place, on failure only the path is visible in the bubble. As far as I see, the output is already captured, but it is not returned to the exception.

Regards, Stefan

domcleal commented 8 years ago

This should now be fixed in 863e4cc7, since 0.3.8.