Fixes #8379 : Add plugin knowledge to foreman_hooks.

theforeman / foreman_hooks

Run custom hook scripts on Foreman events

http://m0dlx.com/blog/Extending_Foreman_quickly_with_hook_scripts.html

GNU General Public License v3.0

56 stars 50 forks source link

Fixes #8379 : Add plugin knowledge to foreman_hooks. #17

Closed bkearney closed 8 years ago

bkearney commented 9 years ago

This includes two changes. 1) Strip the module name off of the class, so that Katello::Product looks like Product 2) Append a plugins asset paths to the Rabl view_paths

The second option uses a new plugin.path attribute if it is available. The path was added by #8325. The plugin assumes an engine layout which is apps/views and app/views/$PLUGIN

bkearney commented 9 years ago

I updated the PR to include a change to the README as well as the code itself.

bkearney commented 9 years ago

@domcleal I force pushed a new version of the request. Changes from the previous version:

Rebased to master
Updated the README per your comment
Updated the indents.

bkearney commented 9 years ago

@domcleal Anything else I need to do on my end?

stbenjam commented 9 years ago

Any news on this? :-)

bkearney commented 9 years ago

@domcleal Made all the changes per your comments. I am not sure about the STI here, see comments above.

domcleal commented 8 years ago

Closing, no activity.