theforeman / foreman_hooks

Run custom hook scripts on Foreman events
http://m0dlx.com/blog/Extending_Foreman_quickly_with_hook_scripts.html
GNU General Public License v3.0
56 stars 50 forks source link

README update, prevent broken pipe error #32

Closed lzap closed 8 years ago

lzap commented 8 years ago

Review of README because Red Hat doco team had a lot of questions when processing this and I decided to fix this. Some comments inline.

Also this fixes EPIPE which can occur when script closes STDIN.

lzap commented 8 years ago

Amended the changes.

domcleal commented 8 years ago

Also this fixes EPIPE which can occur when script closes STDIN.

If you could split documentation updates from bug fixes, that'd be appreciated.

lzap commented 8 years ago

If you could split documentation updates from bug fixes, that'd be appreciated.

Sure, fixed both your comments.

Later, Lukas #lzap Zapletal

domcleal commented 8 years ago

Merged, thanks @lzap.