theforeman / foreman_hooks

Run custom hook scripts on Foreman events
http://m0dlx.com/blog/Extending_Foreman_quickly_with_hook_scripts.html
GNU General Public License v3.0
56 stars 50 forks source link

Add shared GitHub Actions workflow for ruby #64

Closed archanaserver closed 6 months ago

archanaserver commented 7 months ago

Used theforeman/actions reusable workflows for the GHA config.

https://github.com/theforeman/actions?tab=readme-ov-file#foreman-plugin-tests

ekohl commented 7 months ago

There, now it actually starts the action and we can see the result.

archanaserver commented 7 months ago

@ekohl They don't have rubocop, should we skip it for now, wdyt?

ekohl commented 7 months ago

Yes, you can skip it.

evgeni commented 7 months ago

Hmm. There are also no test tasks defined. "Cool"

archanaserver commented 6 months ago

How can I work in this @evgeni? and where also it is not defined :/

ekohl commented 6 months ago

Looking at https://ci.theforeman.org/job/test_plugin_matrix/5868/ruby=2.7,slave=fast/console it only calls rake db:seed to verify. But it's interesting that there is a test file. I think that hasn't ran in forever.

archanaserver commented 6 months ago

Looking at https://ci.theforeman.org/job/test_plugin_matrix/5868/ruby=2.7,slave=fast/console it only calls rake db:seed to verify. But it's interesting that there is a test file. I think that hasn't ran in forever.

@ekohl would you mind expanding it a little more? I can't quite understand it.