theforeman / foreman_omaha

Foreman Plugin to allow CoreOS Updates via Omaha Protocol.
GNU General Public License v3.0
8 stars 8 forks source link

Replace charts with react components #32

Closed kamils-iRonin closed 3 years ago

kamils-iRonin commented 5 years ago

This closes #20 image

theforeman-bot commented 5 years ago

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

ohadlevy commented 5 years ago

can this somehow be added to the plugin template at https://github.com/theforeman/foreman_plugin_template ?

On Tue, Dec 11, 2018 at 2:17 PM Avi Sharvit notifications@github.com wrote:

@sharvit commented on this pull request.

In .eslintrc https://github.com/theforeman/foreman_omaha/pull/32#discussion_r240586339 :

@@ -0,0 +1,49 @@ +{

  • "root": true,

I would strongly recommend using the same configurations as in the core using eslint-plugin-patternfly-react https://github.com/patternfly/patternfly-react/tree/master/packages/eslint-plugin-patternfly-react .

See: theforeman/foreman@839bcbb https://github.com/theforeman/foreman/commit/839bcbbd1499e6dd377ef8cf7f4ba67742c55eed

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/theforeman/foreman_omaha/pull/32#discussion_r240586339, or mute the thread https://github.com/notifications/unsubscribe-auth/AABOx40swVYqNiuyuLp_j9jQFXdGgapYks5u36JjgaJpZM4W-K1v .

timogoebel commented 5 years ago

As discussed with @ekohl on IRC, I'd wait for the packaging issues to be solved before merging this PR.

timogoebel commented 5 years ago

[test foreman_omaha]

ezr-ondrej commented 3 years ago

I believe now it should be much easier to finish this.

kamils-iRonin commented 3 years ago

closed in favor of https://github.com/theforeman/foreman_omaha/pull/55