search

theforeman / foreman_omaha

Foreman Plugin to allow CoreOS Updates via Omaha Protocol.
GNU General Public License v3.0
8 stars 8 forks source link

Fixes #28992 - Add description to plugin roles #43

Closed stejskalleos closed 4 years ago

stejskalleos commented 4 years ago

PR is part of Add default descriptions to all roles added from plugins task.

theforeman-bot commented 4 years ago

Can one of the admins verify this patch?

stejskalleos commented 4 years ago

Hi @timogoebel , can you please give me some good description for the roles? Thanks

timogoebel commented 4 years ago

Does this require a minimum Foreman version?

stejskalleos commented 4 years ago

Does this require a minimum Foreman version?

No it doesn't, it's not a new feature.

timogoebel commented 4 years ago

@stejskalleos: Great. Is this ready to review (& merge)? The title still shows the WIP label.

stejskalleos commented 4 years ago

Sorry, forgot to update title. It's ready to merge, if nobody else has any other comments or ideas.

stejskalleos commented 4 years ago

Hi @timogoebel, I just found that role descriptions actually requires minimal version of foreman 1.20+.

stejskalleos commented 4 years ago

[test foreman_omaha]

timogoebel commented 4 years ago

Thanks, @stejskalleos! And sorry for the delay!