Replace charts with react components

theforeman / foreman_omaha

Foreman Plugin to allow CoreOS Updates via Omaha Protocol.

GNU General Public License v3.0

8 stars 8 forks source link

Replace charts with react components #55

Closed kamils-iRonin closed 2 years ago

kamils-iRonin commented 3 years ago

This closes #20

~~This needs https://github.com/theforeman/foreman/pull/8228~~

ezr-ondrej commented 3 years ago

If we could replace it with mounting the ChartBox components directly, it would make me very happy xD We could then deprecate the flot_pie_chart more easily.

ezr-ondrej commented 3 years ago

Maybe we can have some rails helper for that, to simplify it if it would help, but I think here it should be pretty straight forward.

ezr-ondrej commented 3 years ago

What is the status here? can we get this in?

laugmanuel commented 2 years ago

@kamils-iRonin can you give an update on this? And rebase if we still need/want this? 😉

ezr-ondrej commented 2 years ago

I belive it should go in :) flot_pie_chart is removed, so these charts just won't work now

kamils-iRonin commented 2 years ago

@laugmanuel rebased and updated the code a bit

laugmanuel commented 2 years ago

@kamils-iRonin looks good so far. But I noticed that the version distribution bar has a blue background and the link is blue as well (see screenshot):

kamils-iRonin commented 2 years ago

@laugmanuel do you mean the bar on the omaha group view page? if so, the link should be white 🤔

laugmanuel commented 2 years ago

@kamils-iRonin , using Foreman 3.1 the link text is blue. The color attribute seems to come from --pf-global--link--Color - maybe it's just a Foreman 3.1 thing.

laugmanuel commented 2 years ago

Thanks @kamils-iRonin