search

theforeman / foreman_omaha

Foreman Plugin to allow CoreOS Updates via Omaha Protocol.
GNU General Public License v3.0
8 stars 8 forks source link

Use extend_template_helpers function to register renderer extension #57

Closed laugmanuel closed 2 years ago

laugmanuel commented 3 years ago

fixes #56

timogoebel commented 3 years ago

Looks good. We have confirmation, that this fixes the issue. CI needs a green light, though.

laugmanuel commented 3 years ago

Looks good. We have confirmation, that this fixes the issue. CI needs a green light, though.

I'll open another PR to fix the pipeline and rebase this afterwards.

timogoebel commented 2 years ago

@laugmanuel: I belive we can rebase & merge this!

laugmanuel commented 2 years ago

I'm wondering if this is still technically needed? Testing with Foreman 3.0 and the recent fixes regarding Foreman >= 2.5, the template rendering now works without this modification here.

timogoebel commented 2 years ago

Thanks!