search

theforeman / foreman_omaha

Foreman Plugin to allow CoreOS Updates via Omaha Protocol.
GNU General Public License v3.0
8 stars 8 forks source link

do not load non-existant charts.js #63

Closed evgeni closed 1 year ago

evgeni commented 1 year ago

We used charts.js from Foreman, but that was dropped in Foreman 3.0 (https://github.com/theforeman/foreman/commit/69379b51a33344de93836950565ecbfae0c4df23) and results in 404 errors when trying to load some pages

Fixes: 28d49d8c43b2f3ae6ea112590074386ab7dd4d18

evgeni commented 1 year ago

:eyes: @laugmanuel @kamils-iRonin ;-)

laugmanuel commented 1 year ago

Can you retrigger Github Actions? I'm not that familiar with the plugin. Can you jump in @kamils-iRonin ?

evgeni commented 1 year ago

for some reason I cannot, but I can force push?

evgeni commented 1 year ago

doesn't look any happier :woman_shrugging:

kamils-iRonin commented 1 year ago

I opened a new PR (https://github.com/theforeman/foreman_omaha/pull/65) to fix the pipeline, I don't think rubocop failure is related to this one

evgeni commented 1 year ago

all :green_apple: