Closed wlma closed 1 year ago
This should be fixed with https://github.com/theforeman/foreman_omaha/commit/18a364ba02e42da912c1af69b03834fc5a9abc1c
@kamils-iRonin what do you think?
@evgeni Yes, I think so. Also, there is a test for ForemanOmaha::OmahaGroup#latest_operatingsystem
Great, thanks for double checking my sanity.
Closing.
Foreman version: 3.6.1 Plugins:
Stack Trace generated with foreman-rake errors:fetch_log:
2023-06-09T10:03:41 [I|app|9c26626c] Started GET "/omaha_groups/3" for 10.101.0.193 at 2023-06-09 10:03:41 +0200 2023-06-09T10:03:41 [I|app|9c26626c] Processing by OmahaGroupsController#show as HTML 2023-06-09T10:03:41 [I|app|9c26626c] Parameters: {"id"=>"3"} 2023-06-09T10:03:41 [W|app|9c26626c] Query method called with non-attribute argument(s): "major::text::integer DESC" 2023-06-09T10:03:41 [I|app|9c26626c] Backtrace for 'Query method called with non-attribute argument(s): "major::text::integer DESC"' error (ActiveRecord::UnknownAttributeReference): Query method called with non-attribute argument(s): "major::text::integer DESC" 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activerecord-6.1.7.3/lib/active_record/sanitization.rb:145:in
disallow_raw_sql!' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activerecord-6.1.7.3/lib/active_record/relation/query_methods.rb:1394:inpreprocess_order_args' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activerecord-6.1.7.3/lib/active_record/relation/query_methods.rb:360:in
order!' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activerecord-6.1.7.3/lib/active_record/relation/query_methods.rb:355:inorder' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/foreman_omaha-5.0.1/app/models/foreman_omaha/omaha_group.rb:31:in
latest_operatingsystem' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/foreman_omaha-5.0.1/app/controllers/omaha_groups_controller.rb:15:inshow' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal/basic_implicit_render.rb:6:in
send_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/abstract_controller/base.rb:228:inprocess_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal/rendering.rb:30:in
process_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/abstract_controller/callbacks.rb:42:inblock in process_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:117:in
block in run_callbacks' 9c26626c | /usr/share/foreman/app/controllers/concerns/foreman/controller/timezone.rb:10:inset_timezone' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:126:in
block in run_callbacks' 9c26626c | /usr/share/foreman/app/models/concerns/foreman/thread_session.rb:32:inclear_thread' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:126:in
block in run_callbacks' 9c26626c | /usr/share/foreman/app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:inset_topbar_sweeper_controller' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:126:in
block in run_callbacks' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/audited-5.3.2/lib/audited/sweeper.rb:16:inaround' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:126:in
block in run_callbacks' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/audited-5.3.2/lib/audited/sweeper.rb:16:inaround' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:126:in
block in run_callbacks' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:137:inrun_callbacks' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/abstract_controller/callbacks.rb:41:in
process_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal/rescue.rb:22:inprocess_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal/instrumentation.rb:34:in
block in process_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/notifications.rb:203:inblock in instrument' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/notifications/instrumenter.rb:24:in
instrument' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/notifications.rb:203:ininstrument' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal/instrumentation.rb:33:in
process_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal/params_wrapper.rb:249:inprocess_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activerecord-6.1.7.3/lib/active_record/railties/controller_runtime.rb:27:in
process_action' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/abstract_controller/base.rb:165:inprocess' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionview-6.1.7.3/lib/action_view/rendering.rb:39:in
process' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal.rb:190:indispatch' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_controller/metal.rb:254:in
dispatch' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/routing/route_set.rb:50:indispatch' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/routing/route_set.rb:33:in
serve' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/journey/router.rb:50:inblock in serve' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/journey/router.rb:32:in
each' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/journey/router.rb:32:inserve' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/routing/route_set.rb:842:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/apipie-dsl-2.5.0/lib/apipie_dsl/static_dispatcher.rb:67:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/apipie-rails-0.8.2/lib/apipie/static_dispatcher.rb:68:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/apipie-rails-0.8.2/lib/apipie/extractor/recorder.rb:137:incall' 9c26626c | /usr/share/foreman/lib/foreman/middleware/libvirt_connection_cleaner.rb:9:in
call' 9c26626c | /usr/share/foreman/lib/foreman/middleware/telemetry.rb:10:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/apipie-rails-0.8.2/lib/apipie/middleware/checksum_in_headers.rb:27:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/tempfile_reaper.rb:15:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/etag.rb:27:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/conditional_get.rb:27:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/head.rb:12:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/http/permissions_policy.rb:22:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/http/content_security_policy.rb:19:in
call' 9c26626c | /usr/share/foreman/lib/foreman/middleware/logging_context_session.rb:22:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/session/abstract/id.rb:266:in
context' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/session/abstract/id.rb:260:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/cookies.rb:697:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/callbacks.rb:27:inblock in call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/callbacks.rb:98:in
run_callbacks' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/callbacks.rb:26:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/actionable_exceptions.rb:18:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/debug_exceptions.rb:29:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/show_exceptions.rb:33:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/railties-6.1.7.3/lib/rails/rack/logger.rb:37:incall_app' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/railties-6.1.7.3/lib/rails/rack/logger.rb:28:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/sprockets-rails-3.4.2/lib/sprockets/rails/quiet_assets.rb:13:incall' 9c26626c | /usr/share/foreman/lib/foreman/middleware/logging_context_request.rb:11:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/remote_ip.rb:81:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/request_id.rb:26:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/method_override.rb:24:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/runtime.rb:22:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/activesupport-6.1.7.3/lib/active_support/cache/strategy/local_cache_middleware.rb:29:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/executor.rb:14:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/sendfile.rb:110:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/ssl.rb:77:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/actionpack-6.1.7.3/lib/action_dispatch/middleware/host_authorization.rb:142:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/secure_headers-6.5.0/lib/secure_headers/middleware.rb:11:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/railties-6.1.7.3/lib/rails/engine.rb:539:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/railties-6.1.7.3/lib/rails/railtie.rb:207:in
public_send' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/railties-6.1.7.3/lib/rails/railtie.rb:207:inmethod_missing' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/urlmap.rb:74:in
block in call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/urlmap.rb:58:ineach' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/rack-2.2.6.4/lib/rack/urlmap.rb:58:in
call' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/puma-5.6.5/lib/puma/configuration.rb:252:incall' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/puma-5.6.5/lib/puma/request.rb:77:in
block in handle_request' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/puma-5.6.5/lib/puma/thread_pool.rb:340:inwith_force_shutdown' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/puma-5.6.5/lib/puma/request.rb:76:in
handle_request' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/puma-5.6.5/lib/puma/server.rb:443:inprocess_client' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/puma-5.6.5/lib/puma/thread_pool.rb:147:in
block in spawn_thread' 9c26626c | /usr/share/foreman/vendor/ruby/2.7.0/gems/logging-2.3.1/lib/logging/diagnostic_context.rb:474:inblock in create_with_logging_context' 2023-06-09T10:03:41 [I|app|9c26626c] Rendered common/500.html.erb within layouts/application (Duration: 2.2ms | Allocations: 960) 2023-06-09T10:03:41 [I|app|9c26626c] Rendered layouts/base.html.erb (Duration: 1.5ms | Allocations: 1316) 2023-06-09T10:03:41 [I|app|9c26626c] Rendered layout layouts/application.html.erb (Duration: 4.1ms | Allocations: 2487) 2023-06-09T10:03:41 [I|app|9c26626c] Completed 500 Internal Server Error in 14ms (Views: 4.9ms | ActiveRecord: 1.4ms | Allocations: 5900)