search

theforeman / foreman_omaha

Foreman Plugin to allow CoreOS Updates via Omaha Protocol.
GNU General Public License v3.0
8 stars 8 forks source link

Rewrite GHA workflow using reusable actions #66

Closed archanaserver closed 7 months ago

archanaserver commented 8 months ago

Updating the GitHub Action workflow by using shared foreman plugin test action: https://github.com/theforeman/actions#foreman-plugin-tests

archanaserver commented 8 months ago

https://github.com/theforeman/foreman_omaha/pull/67

evgeni commented 8 months ago

Can you please include the commit from #67 in here so we see it passes?

archanaserver commented 8 months ago

argh no! so many checks are failing now, will take a look.

evgeni commented 8 months ago

I think we can get away with replacing https://github.com/theforeman/foreman_omaha/blob/ca48aa882dfa8d41066c426535cd00b6a9cdb8f8/foreman_omaha.gemspec#L22-L25 with theforeman-rubocop ~> 0.0.6 (to match foreman core)

Looking at @theforeman/omaha if they are OK with such a change?

The alternative would be to bump rubocop-rails ~> 2.8.1 to match core

ekohl commented 7 months ago

I see @laugmanuel is not part of the omaha team, but is this plugin still used within DM?

laugmanuel commented 7 months ago

@ekohl, we're no longer using this plugin and therefore don't really have any plans on contributing features to it.

I wonder who is actually using this plugin today? I guess the K8s landscape has changed quite a lot in the recent years and many are probably using other products to provision/maintain/update K8s environments.

Long story short: I wonder if it's worth putting effort into this plugin?

ekohl commented 7 months ago

Long story short: I wonder if it's worth putting effort into this plugin?

Thanks for answering that, because it's exactly the question I had. I'm inclined to deprecate it for Foreman 3.10 & remove with 3.11.

laugmanuel commented 7 months ago

Long story short: I wonder if it's worth putting effort into this plugin?

Thanks for answering that, because it's exactly the question I had. I'm inclined to deprecate it for Foreman 3.10 & remove with 3.11.

Maybe @timogoebel can give his opinion as the original plugin author. From my side it's fine to deprecate the plugin.

ekohl commented 7 months ago

Proposing to retire it in https://community.theforeman.org/t/retire-foreman-setup-plugin/36594

Edit: I meant https://community.theforeman.org/t/retire-foreman-omaha-plugin/36643

timogoebel commented 7 months ago

@ekohl: Thank for taking care of this. This plugins should indeed be retired.

Night-night 🌙 !