search

theforeman / foreman_puppet

https://theforeman.org/plugins/foreman_puppet/
GNU General Public License v3.0
7 stars 25 forks source link

Hammer plugin #37

Closed ezr-ondrej closed 2 years ago

ezr-ondrej commented 4 years ago

https://github.com/amirfefer/hammer-cli-foreman-puppet

nadjaheitmann commented 3 years ago

I can work on the hammer plugin as well.

https://github.com/amirfefer/hammer-cli-foreman-puppet

Is this the current status?

ezr-ondrej commented 3 years ago

It would be awesome, if you could team up with @amirfefer on this.

Current status

There is a draft @ekohl started to clean up the core code prior it's removal, that would be great to finalize before moving to the plugin. Ewoud is saying he struggles to find time to finish it, so if you'd like to take that, that would be appreciated: https://github.com/theforeman/smart-proxy/pull/771

@amirfefer recently resumed work on the plugin, so probably first asking him to push the recent changes prior to sending PRs, but his repo is indeed the primary develop repo as of now, before we move it under theforeman org.

nadjaheitmann commented 3 years ago

Thanks for the update. I will get in contact with @ekohl and @amirfefer about the topics.

ekohl commented 3 years ago

@ezr-ondrej my PR is not really about hammer but really about the Smart Proxy modules.

ezr-ondrej commented 3 years ago

My bad, I've messed things up. Weren't there something similar for hammer, or am I just imagining stuff?

nadjaheitmann commented 3 years ago

Let me know if there is another PR that needs fixing before the Hammer plugin can move on. Right now, I am waiting for @amirfefer to provide some up-to-date information.

nadjaheitmann commented 3 years ago

Same as for #150, shall we close it? Hammer puppet plugin is up and working :) we can open new issues if necessary.

ezr-ondrej commented 2 years ago

Closing as it is in Done column but not closed