Schedule a random delay before execution

[ShimShtein]

Adding another option for randomizing task schedule. This correlates to option 1 in https://github.com/theforeman/foreman_rh_cloud/pull/781

The idea is to wait in the main task before starting the execution of the sub-tasks.

[ShimShtein]

This looks good, although I would prefer not hijacking the part action with the module. So instead of having a module, we'd have a new action class and a module, the new action would serve as the delay itself and the module would provide just a shortcut to insert the "blocking" action into the right place within the execution plan

If I understand you correctly, you would like to have a DelayAction that would do the delay, and then execute the actual code. It means that I would need to schedule the DelayAction and pass it the actual class as a parameter and I wasn't sure how I can pull it off with recurring action.

[adamruzicka]

have a DelayAction that would do the delay, and then execute the actual code

No, the delay action would only do the delay and that would be all. What I had in mind is really similar to what you have here, it just allows the top-level action to have its own #run.

It will be easier to explain with an example

module DelayedStart
  extend ActiveSupport::Concern

  def after_delay(delay = nil, &block)
    sequence do
      plan_action(DelayAction, delay: delay)
      concurrence(&block)
    end
  end
end

class DelayAction < ::Dynflow::Action
  def run
    # plan_event + suspend or finish
  end
end

module Async
  class GenerateAllReportsJob < ::Actions::EntryAction
    # ...
    include ForemanInventoryUpload::Async::DelayedStart

    def plan
      after_delay do
        # whatever
      end
    end
  end
end

[ShimShtein]

@adamruzicka now it looks much better, thanks for the suggestion!

[ShimShtein]

@adamruzicka fixed the nitpicks, ready for another round

[Ron-Lavi]

yes, setting up the environment and I will try to test it