search

theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 32 forks source link

Bump container to foreman 3.5 #788

Closed ShimShtein closed 1 year ago

adamruzicka commented 1 year ago

Would be nice it it actually run the tests with the newly built container. Anyway, lgtm

ShimShtein commented 1 year ago

@adamruzicka it actually does: https://github.com/theforeman/foreman_rh_cloud/actions/runs/3631261408/jobs/6125660397#step:4:12276 Basically it builds a container and runs the default action, which is run rubocop and ruby tests.

adamruzicka commented 1 year ago

Ah, even better, I didn't expect it there.