Closed chris1984 closed 10 months ago
Looks like the JS tests GitHub action is failing to even start with our favorite thing
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in >sync. Please update your lock file with `npm install` before continuing. npm ERR! npm ERR! npm ERR! Invalid: lock file's cosmiconfig-typescript-loader@4.0.0 does not satisfy cosmiconfig-typescript-loader@~4.3.0 npm ERR!
looks like you need either to update the package.json with `"cosmiconfig-typescript-loader": "^4.0.0", or update the package-lock.json.plugin with a newer version of "cosmiconfig-typescript-loader"
cosmiconfig-typescript-loader
Blah that didn't work, I remember we had to pin that to 4.0.0 a while back because the tests started to fail and we got a dependency error. @ShimShtein can probably tell more about it
Since we are close to the dev freeze, i'm going to close this one out and just open a PR for the backend change and then expose that api to the rails controller so hammer can use it. We can add the UI button at a later time.
Need to figure out why i'm getting
And also update the JS snapshots so tests will pass.
@ShimShtein let me know if the backend change looks fine, I sent a link to this pr to @Ron-Lavi so he can help with the JS stuff
Looks like the JS tests GitHub action is failing to even start with our favorite thing