use shared github workflow to run tests

theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud

GNU General Public License v3.0

6 stars 30 forks source link

use shared github workflow to run tests #866

Closed evgeni closed 6 months ago

evgeni commented 8 months ago

cold cache: 13m 24s (https://github.com/theforeman/foreman_rh_cloud/actions/runs/7567480704/job/20606728804) warn cache: 11m 18s (https://github.com/theforeman/foreman_rh_cloud/actions/runs/7567634004/job/20607196990) old action: 7m 50s (https://github.com/theforeman/foreman_rh_cloud/actions/runs/7531259398/job/20499435028)

so, while slower, certainly not bad

ekohl commented 8 months ago

Should this also drop the "build container" workflows, since they're no longer needed?

ekohl commented 8 months ago

This fails in a migration, probably because the plugin can't be installed after Foreman has already been installed. I suppose that's another difference in migrations. Perhaps our reusable action should test both approaches.

evgeni commented 7 months ago

This fails in a migration, probably because the plugin can't be installed after Foreman has already been installed. I suppose that's another difference in migrations. Perhaps our reusable action should test both approaches.

Correct.

I've opened https://projects.theforeman.org/issues/37076 to track this in Katello
I've opened https://github.com/theforeman/actions/pull/32 to allow us to skip this while :point_up: is not fixed
The reusable action does test db:seed in the "normal" flow (install foreman and plugin in the same run) since https://github.com/theforeman/actions/commit/590eefb499d35a190f851b1cb44459bb7f94abbd, so no action needed

evgeni commented 7 months ago

I've split out some of the changes here into #867 and #868 as they are only indirectly related to the whole GHA change

ShimShtein commented 7 months ago

@evgeni , can you define the version of Foreman you want to use for the tests? I see the action uses the develop branch by default. It won't be good enough for stable branches.

evgeni commented 7 months ago

Of course, which ones would you like? 3.9 and develop?

evgeni commented 7 months ago

Of course, which ones would you like? 3.9 and develop?

I've implemented 3.9 an develop now, what do you think? :)

ekohl commented 6 months ago

@ShimShtein could you have a look?

ShimShtein commented 6 months ago

Merged, thanks @evgeni !

Do you expect we will need to cherry-pick this one to older branches of the plugin?

evgeni commented 6 months ago

Nah, as long as it's in the one for 3.10, we're good

ShimShtein commented 6 months ago

Which version of Katello are we using? I will probably need to freeze Katello and REX versions. Is there an option to do that, or do I need to freeze them in the gemspec?

evgeni commented 6 months ago

Whichever the gemspec allows is used, yeah.