Closed evgeni closed 10 months ago
Also, the target Ruby version needs to match. Looks like the config is pinned to Foreman 2.3 even though this branch is for Foreman 3.9. https://github.com/theforeman/foreman_rh_cloud/blob/ebcbeed9d6707fa2760c14490ee8824e25ef2d7b/.rubocop.yml
I wanted to tackle that once the first round of auto-fixes is in ;-)
I mostly mention it because https://github.com/theforeman/foreman_rh_cloud/pull/866 fails on it.
hmm, given it takes the TargetRubyVersion from theforeman-rubocop… shall we set it to 2.5+ for now, or add it to rubocop_todo to fix properly?
Also, the target Ruby version needs to match. Looks like the config is pinned to Foreman 2.3 even though this branch is for Foreman 3.9. https://github.com/theforeman/foreman_rh_cloud/blob/ebcbeed9d6707fa2760c14490ee8824e25ef2d7b/.rubocop.yml