search

theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 30 forks source link

Remove subscription label from report slice #882

Closed chris1984 closed 4 months ago

chris1984 commented 4 months ago

With SCA being the default, this is now longer needed and has been removed from Katello so it throws an error in our tests

chris1984 commented 4 months ago

Tests didn't run because we don't have it enabled for this branch: https://github.com/theforeman/foreman_rh_cloud/blob/v10/.github/workflows/ruby_tests.yml#L5-L6

Should we turn it on for V10 or leave it off until we get a stable foreman branch that we want to release with?

ShimShtein commented 4 months ago

Should we turn it on for V10 or leave it off until we get a stable foreman branch that we want to release with?

Let's test against develop and then switch to stable, once it's out.

ShimShtein commented 4 months ago

Can you please turn the testing on, rebase and make sure the tests pass before we merge this one?

chris1984 commented 4 months ago

Can you please turn the testing on, rebase and make sure the tests pass before we merge this one?

Does this look familiar? https://github.com/theforeman/foreman_rh_cloud/actions/runs/8989741452/job/24693544251?pr=882

ShimShtein commented 4 months ago

This is the commit that caused the test to fail: https://github.com/theforeman/foreman_rh_cloud/commit/32866dc50f59c52e30a0ab84602661e22ee3c4ac It means that we prefer RAW_POST_DATA over parameters sent to the controller. I think we should change the test accordingly