search

theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 30 forks source link

Add Zeitwerk loader support #892

Open ofedoren opened 1 month ago

ofedoren commented 1 month ago

Not sure what's the right branch for opening PRs against :/

Not mergeable until deps are merged.

ofedoren commented 1 week ago

Requires 4 plugins: tasks, rex, ansible, katello, I suggest revisiting this plugin after the deps are merged.

Not quire ready, probably some additional changes will be made.

ofedoren commented 3 days ago

Since it's green now, should I remove the last commit? Or leave it for you to decide when there is more appropriate timing?

evgeni commented 2 days ago

I'd remove it, but I am also not the maintainer of this plugin :)

jeremylenz commented 1 day ago

@ofedoren is this ready for merge?

ekohl commented 1 day ago

This has a similar issue as what https://github.com/theforeman/foreman_virt_who_configure/pull/201 shows. Right now it's only testing with a released version of Katello, but that doesn't contain the Zeitwerk changes. Previously it added a gemfile.d file to use a git version, but now CI is red. If you add that change, katello-devel breaks.

Edit: I'm also entirely unsure how this repo does branching. The default is a v10 branch and there is no concept of master/develop so does that mean it first needs to change the default branch to v11 since it's breaking? That's why I'm not merging this now.