search

theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 32 forks source link

Replace "Satellite" with "Foreman" in user-facing strings. #897

Closed Thorben-D closed 1 month ago

Thorben-D commented 2 months ago

This PR provides a starting point for un-branding this plugin.

Only user-facing strings are un-branded right now. Un-branding environment variables or hash-keys would either break existing usages or create a bit of a mess. I am not sure that would be worth the trouble...

Using foreman_theme_satellite in conjunction with this plugin re-applies the branding.

Thorben-D commented 2 months ago

Tests should be working now!

ShimShtein commented 2 months ago

Let's wait for the branching, and then push the PR. We are after the strings were sent to translations, so changing the templates will result in breakage.

sbernhard commented 2 months ago

Is the branching already done @ShimShtein ? maybe have a look at https://github.com/theforeman/foreman_rh_cloud/pull/901, too

chris1984 commented 2 months ago

Is the branching already done @ShimShtein ? maybe have a look at #901, too

Branching will happen after we go GA downstream. There is discussion still about the branch name for the next version too.

Thorben-D commented 1 month ago

Rebased to "develop"