theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 30 forks source link

Replace "Satellite" with "Foreman" in user-facing strings. #897

Open Thorben-D opened 2 weeks ago

Thorben-D commented 2 weeks ago

This PR provides a starting point for un-branding this plugin.

Only user-facing strings are un-branded right now. Un-branding environment variables or hash-keys would either break existing usages or create a bit of a mess. I am not sure that would be worth the trouble...

Using foreman_theme_satellite in conjunction with this plugin re-applies the branding.

Thorben-D commented 2 weeks ago

Tests should be working now!

ShimShtein commented 2 weeks ago

Let's wait for the branching, and then push the PR. We are after the strings were sent to translations, so changing the templates will result in breakage.