search

theforeman / foreman_rh_cloud

a plugin to Foreman that generates and uploads reports to the Red Hat cloud
GNU General Public License v3.0
6 stars 31 forks source link

Replacements for access.redhat.com/* links. #912

Open Thorben-D opened 2 weeks ago

Thorben-D commented 2 weeks ago

I found quite a few links that refer the user to access.redhat.com/*. Some of these are already dead, so I think it would be wise for us to find replacements or verify that the links will continue to be available in the future:

  1. [] https://access.redhat.com/documentation/en-us/red_hat_insights/2023/html/red_hat_insights_remediations_guide/host-communication-with-insights_red-hat-insights-remediation-guide#uploading-satellite-host-inventory-to-insights_configuring-satellite-cloud-connector

  2. [] https://access.redhat.com/documentation/en-us/subscription_central/2020-04/html/getting_started_with_subscription_watch/assembly-about-subscriptionwatch

  3. [] https://access.redhat.com/node/54483

  4. [] https://access.redhat.com/node/3359651

  5. [] https://access.redhat.com/node/4134081

  6. [] https://access.redhat.com/node/3560291

  7. [] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/managing_monitoring_and_updating_the_kernel/installing-and-configuring-kdump_managing-monitoring-and-updating-the-kernel#memory-requirements-for-kdump_supported-kdump-configurations-and-targets

  8. [] https://access.redhat.com/solutions/916043

  9. [] https://access.redhat.com/security/vulnerabilities/smbloris

  10. [] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/kernel_administration_guide/kernel_crash_dump_guide#sect-kdump-memory-requirements

  11. [] https://access.redhat.com/solutions/916043

  12. [] https://cert-api.access.redhat.com/

  13. [] https://access.redhat.com/node/3359651

  14. [] https://access.redhat.com/documentation/en-us/subscription_central/2020-04/html/getting_started_with_subscription_watch/assembly-about-subscriptionwatch

I'll create a PR once we checked off every link.

ShimShtein commented 5 days ago

@MariaAga what is our policy about links embedded into the UI, like this one: https://github.com/theforeman/foreman_rh_cloud/blob/e2ea8640c1014ef6895ed435cf4b2b31a82a39c7/webpack/ForemanInventoryUpload/Components/PageHeader/components/PageDescription/PageDescription.js#L44-L50

I suppose we need to make sure this link goes through our links controller. What would be the best way to do it?

ShimShtein commented 5 days ago

@Thorben-D Some of those links, like https://github.com/theforeman/foreman_rh_cloud/blob/e2ea8640c1014ef6895ed435cf4b2b31a82a39c7/webpack/InsightsCloudSync/Components/InsightsTable/__tests__/fixtures.js#L23

come from fixtures. There is no point in changing those. We can remove them from the list right away.

MariaAga commented 4 days ago

We dont have a links controller in JS, I suppose we could make some tests that check that links are not dead in this repo. I only found an example for an external link in katello and its not treated specially <a href="https://access.redhat.com/articles/1586183"> and 

export const SUBSCRIPTIONS_SERVICE_URL = 'https://console.redhat.com/subscriptions'; 
  <a
    href={SUBSCRIPTIONS_SERVICE_URL}
    className="btn btn-default"
    target="_blank"
    rel="noreferrer"
  >