search

theforeman / foreman_statistics

Foreman plugin to present statistics and trends
https://theforeman.org/plugins/foreman_statistics/
GNU General Public License v3.0
0 stars 6 forks source link

Fix url scope for new_link #22

Closed ezr-ondrej closed 3 years ago

ezr-ondrej commented 4 years ago

In theforeman/foreman@85a3ebb22fbac6167b20635820a4ce7119f11f96 (https://github.com/theforeman/foreman/pull/8096) we have enabled the usage of engine for these. But this brought an issue, that the scope defaults to the Core routes. So currently we need to use the engine even if the scope would be fine by default.

ezr-ondrej commented 3 years ago

Does this mean that this helper is now broken for other plugins that relied on the old behaviour?

For plugins that use isolated engine. That means bootdisk, but I have not found an occurence there, so we should be fine.