theforeman / forklift

Helpful deployment scripts for Foreman and Katello
https://theforeman.github.io/forklift
GNU General Public License v3.0
183 stars 200 forks source link

Fix stagingyum repositories URLs #1765

Closed wbclark closed 8 months ago

wbclark commented 8 months ago

https://stagingyum.theforeman.org/foreman/staging/el8/x86_64/ returns 404, it should be https://stagingyum.theforeman.org/foreman/nightly/el8/x86_64/

This fixes the issue for those who don't have in their box yaml: katello_repositories_version: nightly

wbclark commented 8 months ago

No, you gotta set the right version. "Staging" is not a version.

it's not clear to me where that's coming from.

I had katello_repositories_version: nightly in my box yaml already so it just worked for me.

But that's already the default for the katello_repositories role: https://github.com/theforeman/forklift/blob/master/roles/katello_repositories/defaults/main.yml#L2

wbclark commented 8 months ago

CC: @ianballou this looks like it should have been working for you already using the defaults -- were you passing some extra variables to your box that were breaking it?

ianballou commented 8 months ago

CC: @ianballou this looks like it should have been working for you already using the defaults -- were you passing some extra variables to your box that were breaking it?

Very likely yes! However I got it to work with:

centos8-katello-devel-2:
  primary: true
  box: centos8-stream
  cpus: 2
  memory: 15000
  ansible:
    playbook: 'playbooks/katello_devel.yml'
    group: 'devel'
    variables:
      ssh_forward_agent: true
      foreman_installer_options:
        - "--foreman-proxy-content-enable-ostree=true"
      foreman_repositories_environment: staging
      katello_repositories_environment: staging
      foreman_repositories_version: nightly
      katello_repositories_version: nightly
ianballou commented 8 months ago

I think we still want to be able to set the repositories version since https://stagingyum.theforeman.org/katello/ for example has both nightly and 4.11. 99% of the time we'll use nightly for katello devel, but maybe some other automation will consume the staging 4.11 rpms.

evgeni commented 8 months ago

Every release pipeline uses those repos to validate them before pushing them live ;)

wbclark commented 8 months ago

Closing as this was not ultimately needed.