theforeman / forklift

Helpful deployment scripts for Foreman and Katello
https://theforeman.github.io/forklift
GNU General Public License v3.0
183 stars 199 forks source link

Switch Katello bats tests to better repo (fix Katello nightly BATS failures) #1806

Closed ianballou closed 5 months ago

ianballou commented 5 months ago

rpm-packages-updateinfo contains an important erratum (the SEA one) that points to the wrong RPMs. rpm-no-comps correctly points to walrus-5.21.

Also added some repo cleanup since the Pulp fixtures reuse RPMs, which causes clashes between the modular and non-modular versions of the RPMs.

Should fixes the Katello nightly pipeline.

Tested against nightly.

ehelms commented 5 months ago

@ianballou looks good, can you address the shell check comments?

ianballou commented 5 months ago

Doing a final full test and then I'll push up the last changes

ianballou commented 5 months ago

@ehelms this is good to go now, finished up my testing.

evgeni commented 5 months ago

For some reason EL9 is failing with this

https://jenkins-foreman.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/foreman-pipeline-katello-rpm-nightly/detail/foreman-pipeline-katello-rpm-nightly/332/pipeline

ehelms commented 5 months ago

Yea - see https://github.com/theforeman/foreman-packaging/pull/10669

evgeni commented 5 months ago

Oooh, that's related?!

ehelms commented 5 months ago

Oooh, that's related?!

Yep, check the output:


[2024-04-04T23:50:20.340Z]     # $ hammer repository delete --organization="${ORGANIZATION}" --product="${PRODUCT}" --name="${YUM_REPOSITORY_2}" --remove-from-content-view-versions=true

[2024-04-04T23:50:20.340Z]     # Repository deleted.

[2024-04-04T23:50:20.340Z]     # $ hammer repository delete --organization="${ORGANIZATION}" --product="${PRODUCT}" --name="${YUM_REPOSITORY_3}" --remove-from-content-view-versions=true

[2024-04-04T23:50:20.340Z]     # Repository deleted.

[2024-04-04T23:50:20.340Z]     # $ echo "::ForemanTasks.sync_task(::Actions::Katello::OrphanCleanup::RemoveOrphans, SmartProxy.pulp_primary)"

[2024-04-04T23:50:20.340Z]     # $ foreman-rake console

[2024-04-04T23:50:20.340Z]     # rake aborted!

[2024-04-04T23:50:20.340Z]     # LoadError: cannot load such file -- irb
evgeni commented 5 months ago

What a way to find a bug ;)