search

theforeman / forklift

Helpful deployment scripts for Foreman and Katello
https://theforeman.github.io/forklift
GNU General Public License v3.0
183 stars 199 forks source link

Drop CentOS 8 and CentOS 7 boxes #1826

Open archanaserver opened 3 months ago

archanaserver commented 3 months ago

https://github.com/theforeman/forklift/issues/1824

archanaserver commented 3 months ago

Test failures are related. You'll also need to remove all references to the centos8-stream box.

Would you mind expanding it a little more, might be I'm missing something here.

While you're at it, perhaps also drop the centos8 box because CentOS Linux 8 has been EOL for much longer.

@ekohl Also for the devel box update to alma here: https://github.com/theforeman/forklift/blob/master/vagrant/boxes.d/99-local.yaml.example do we want to update to centos9-stream but also add alma8 or 9 there or only alma update? Like here(https://github.com/theforeman/forklift/pull/1820) they are trying to do both for katello boxes and I can't understand.

archanaserver commented 3 months ago

Ah I just saw what I ask is already fixed in here https://github.com/theforeman/forklift/pull/1820#issuecomment-2152862825

archanaserver commented 3 months ago

@ekohl would you mind reviewing the recent changes once?

archanaserver commented 2 months ago

@ekohl i'm not quite sure about the changes i have made here, would you mind looking it :/

ehelms commented 2 months ago

I suppose we should also drop CentOS 7 boxes as well?

archanaserver commented 2 months ago

I'm debating the katello_devel test pipeline. AFAIK it's been broken for a long time and in theforeman/jenkins-jobs@44ddb48 (2022) we dropped the pipeline. Perhaps just get rid of the code as well?

Since it has been broken and dropped, i believe it make sense to remove the code. i've updated the PR.

Then as @ehelms suggested, do the same for centos7. Perhaps in this PR, perhaps in a separate.

I also suggested we can drop some old versions.

Also #1832

evgeni commented 1 month ago

Ansible part LGTM, didn't look at the rest.

archanaserver commented 1 month ago

@ekohl does it looks good? i'll try splitting it on separate PR after that.

archanaserver commented 3 weeks ago

Could you submit things as separate PRs? Where one depends on another you can wait with submitting it. I at least think that the katello_devel pipeline drop is incomplete, because in 264a2bf you update a config file for that pipeline. If you drop a pipeline, it also doesn't need any configuration anymore.

@ekohl i've tried splitting the work in separate PRs, https://github.com/theforeman/forklift/pull/1841 depends on rest, we can look on this first. i'll add rest of the PRs in draft as if now, will update things once we start merging things.