search

theforeman / forklift

Helpful deployment scripts for Foreman and Katello
https://theforeman.github.io/forklift
GNU General Public License v3.0
183 stars 199 forks source link

centos7 and centos8 name update #1832

Open archanaserver opened 2 months ago

archanaserver commented 2 months ago

Ref: https://github.com/theforeman/forklift/pull/1826#pullrequestreview-2145729290

archanaserver commented 2 months ago

Marked this as draft for now. I'll take a look on this once again once https://github.com/theforeman/forklift/pull/1826 gets merged.

ekohl commented 2 months ago

https://github.com/theforeman/forklift/pull/1833 created conflicts here.

archanaserver commented 1 month ago

Thanks @ekohl, as per the review, I've made some changes.

archanaserver commented 1 month ago

this is just a note- i'll continue working on this PR once #1826 is merged. i got a bit confused and i guess, i might have mixed up some changes 😕

archanaserver commented 4 days ago

Note: I'll have to test the changes once again.