search

theforeman / forklift

Helpful deployment scripts for Foreman and Katello
https://theforeman.github.io/forklift
GNU General Public License v3.0
183 stars 200 forks source link

upgrade fails when forklift used as part of sat-deploy #582

Open thomasmckay opened 6 years ago

thomasmckay commented 6 years ago

When the foreman-release-scl package is not present, this step fails https://github.com/theforeman/forklift/blob/master/roles/foreman_installer/tasks/upgrade.yml . It already exists as a step in https://github.com/theforeman/forklift/blob/master/roles/foreman_repositories/tasks/main.yml . Is it safe to remove from upgrade.yml?

ekohl commented 6 years ago

It is good to update packages with yum repo files but we could change it to *release* so it also covers things like epel-release and others but gracefully skip foreman-release-scl if it's not present. Would that be a good solution?