Request for Enhanced Testing and Ruby v3 Compatibility in hammer-cli-foreman-salt

theforeman / hammer_cli_foreman_salt

CLI plugin for Salt support

Other

4 stars 6 forks source link

Request for Enhanced Testing and Ruby v3 Compatibility in hammer-cli-foreman-salt #7

Open archanaserver opened 1 year ago

archanaserver commented 1 year ago

@sbernhard I'm working on upgrading Ruby v3 for hammer-cli and its plugins. However, I noticed that hammer-cli-foreman-salt lacks test suites for Ruby version compatibility and Rake tasks for RuboCop checks.

Is there a plan to add these to improve the project's stability and maintainability? I'm willing to help with the implementation.

dosas commented 7 months ago

Thanks for raising this topic:

Will there be a common github actions workflow similar to the foreman plugins? Or Should this just look like: https://github.com/theforeman/hammer-cli/blob/master/.github/workflows/unit_tests.yaml
Regarding rubocop: I created a PR to update to 0.1.0 (according to https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239)

dosas commented 6 months ago

@archanaserver we implemented the ci rubocop checks. If you could help us with the test suites for Ruby version compatibility that would be great.